-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter starting to serve HEVC video files #711
Comments
Pushed a hotfix to exclude HEVC versions of media where possible. This still breaks https://twitter.com/blephin_/status/1767231724621062406 because it only is encoded in HEVC (which also means it doesn't work in Firefox at all) But this will fix posts like https://twitter.com/denfaminicogame/status/1767329323206525435 where a lower quality h264 version is available |
There is still an avc1 fallback, the issue there is that for some reason Twitter isn't including it in the m3u8 for the amplify_video type uploads. (These are the results I get for that specific Tweet) So instead, when requesting the Edit: Ah it seems you already do enumerate the variants, having looked at the code now. So yeah just need to also ignore the m3u8 as well, but only if there is an AVC1 variant listed.... |
I appear to have implemented the fix improperly, stand by |
Okay I pushed a better fix that filters it properly, my previous fix was incomplete and broke with the formats in a different order, oops |
I'm getting a lot of videos where the embed doesn't work on the iOS app, is this the reason? |
I'm not sure if this is the exact same problem, but I'm encountering a video embed problem with Telegram. The tweet in question: When linked via fxtwitter the video don't embed correctly and instead just shows up as a photo. The video that fxtwitter supplies: No idea if this is HEVC somehow leaking out or what's going on. |
Telegram supports transcoding HEVC videos, might be 20 MB limit? I'll look at that tomorrow it's getting late here haha |
I’m having an issue where the embed links don’t play for some reason, here’s a screen recording of it https://github.com/FixTweet/FxTwitter/assets/36827792/32269173-e1f2-415c-8b2b-929d3645f2fa |
I'm blaming Discord mobile being the buggy mess that it is, as it plays on desktop just fine. |
In my experience it doesn't play properly on Desktop (Windows) also. Often when video doesn't work on Mobile, on Desktop it'll play, but impossible to seek into the video. If you click somewhere along the progress bar, the video restarts from 0. |
If I remember correctly, this is caused by the lack of a specific HTTP header or something of the sort, I don't think it has to do at all with the format of the video. |
Discord calculates it based on the metadata length of the file. If the metadata length is incorrect, the seek bar will have weird behavior. |
FYI Discord started supporting HEVC videos as of yesterday (?), so if Twitter starts serving HEVC videos again (and also for videos from that timeframe, such as this one) the workaround is no longer necessary. EDIT: just learned that they aren't playing properly on the Windows desktop client yet (despite playing fine on web, mobile and Mac desktop client), only the audio plays. It's probably some minor Electron issue and should hopefully be fixed by Discord soon. EDIT2: they fixed the Windows Desktop client, HEVC videos play fine in all platforms now. |
Example tweet, found in the wild: https://twitter.com/blephin_/status/1767231724621062406
The text was updated successfully, but these errors were encountered: