Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in collection names #31

Open
BrunoRoemers opened this issue Aug 9, 2024 · 1 comment
Open

Allow spaces in collection names #31

BrunoRoemers opened this issue Aug 9, 2024 · 1 comment

Comments

@BrunoRoemers
Copy link

Expected Behavior

ODM can handle spaces in collection ids. The official restrictions on collection ids are documented here: https://firebase.google.com/docs/firestore/quotas#limits

Actual Behavior

ODM refuses to generate code when a collection id containing a space is passed to @Collection().

Relevant LOCs: https://github.com/FirebaseExtended/firestoreodm-flutter/blob/main/packages/cloud_firestore_odm_generator/lib/src/collection_data.dart#L341

Unfortunately we have a few collections with spaces in their names, which blocks us from fully adopting the Cloud Firestore ODM.

Hacky Workaround

  1. Temporarily remove the space of the collection name; i.e. @Collection('hello world') becomes @Collection('helloworld')
  2. Run code generator (works)
  3. Edit the generated file; add the space again

This is a maintenance nightmare though.

@rrousselGit
Copy link
Contributor

Sure. Fancy making a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants