Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Undo is removing the whole multiline code instead of current line. #362

Open
mbsyaswanth opened this issue Apr 8, 2020 · 2 comments
Open

Comments

@mbsyaswanth
Copy link

mbsyaswanth commented Apr 8, 2020

Version info

Firebase: 7.13.2 npm package

Firepad: 1.5.10

Ace: react-ace - 8.0.0

Test case

http://plnkr.co/edit/pB0OPUMsaDgeQKsL

Steps to reproduce

Guess this is the same with any kind of firepad integration with ace. Use the above link to test this behaviour.

Expected behavior

when i enter multiple lines of code, line by line and press ctrl+z(undo) . I expect the undo function to remove only the code that i am entering in current line. you can test this in expected behaviour in ace editor demo - http://securingsincity.github.io/react-ace/

Actual behavior

when i enter multiple lines of code, line by line and press ctrl+z(undo) , it removes all the code in the editor. use the link provided in testcase section above

@samtstern
Copy link
Contributor

@mbsyaswanth can you explain what you mean by "enter multiple lines of code"? Do you mean pasting multiple lines in at once or do you mean typing a few lines of code manually?

@adamjimenez
Copy link
Contributor

@mbsyaswanth can you explain what you mean by "enter multiple lines of code"? Do you mean pasting multiple lines in at once or do you mean typing a few lines of code manually?

I'm sure he means typing in a few lines of code manually. I can reproduce this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants