Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An academic question #40

Open
DeviPrasad opened this issue Feb 5, 2024 · 2 comments
Open

An academic question #40

DeviPrasad opened this issue Feb 5, 2024 · 2 comments

Comments

@DeviPrasad
Copy link

I've been reading this code while learning the field operations from the ground up. I'm also re-implementing the ideas in Rust on my own so I understand things better.
I noticed that in the field implementation, 'SetBytes' and 'Bytes' (bytes) do not appear to be symmetric. I thought it would be nice if the code makes their complementary nature more explicit.

I tried it out in Rust, and it reads better, I thought.
https://github.com/DeviPrasad/dev-tech-write/blob/main/techauth/tech/cryptography/code/c25519/src/field.rs#L431

Would it make sense if I try to write a Go version of the same? Would you like to comment?

@FiloSottile
Copy link
Owner

I am glad the codebase is being useful in learning!

I am not sure what change you are suggesting, can you give me a rough example?

@DeviPrasad
Copy link
Author

Thanks!
I will share a snippet of Go code here to show the basic idea. That's on me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants