Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor to read file from bytes #100

Open
suou-ryuu opened this issue Jun 7, 2023 · 5 comments
Open

Constructor to read file from bytes #100

suou-ryuu opened this issue Jun 7, 2023 · 5 comments

Comments

@suou-ryuu
Copy link

Currently the only constructor is new HeifImage(<someFilePath>) however my use-case is to process an image downloaded via HTTP, so I only have access to the image bytes.
Would it be possible to add a constructor to the effect of new HeifImage(<someByteArray>)?

@mitchelsellers
Copy link
Collaborator

@suou-ryuu this is a great recommendation. I believe the best overall solution here would be to allow you to pass a Stream as that matches the typical structure.

Let us review

@suou-ryuu
Copy link
Author

@mitchelsellers Sorry to pester, is there any update on this?

@mitchelsellers
Copy link
Collaborator

I will look at addressing this in the coming week

@suou-ryuu
Copy link
Author

Brilliant, thank you.
And sorry for being pushy

@suou-ryuu
Copy link
Author

@mitchelsellers Sorry to bug you again.
Is there any update on this?

(I've tried to get the library set up locally (I figured I'd implement it myself and submit a PR) but I'm having compilation issues with CMAKE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants