Added option to stop and resume download #732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like "pause" might be better wording for this case. Also, it should probably replace the "Cancel" button. Clicking on "Pause" would change the "Pause" button to "Cancel" and have "Resume" button to appear on the right side. |
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
from
0cb8b13
to
e9202a5
Compare
gastoner
force-pushed
the
allow_pausing_iso_automatic_download
branch
from
e9202a5
to
111c84a
Compare
|
@grulja Rebased after |
grulja
requested changes
Oct 4, 2024
There was a problem hiding this comment.
You didn't rebase properly and this change includes one of my changes I pushed recently.
I'm still unsure how to integrate this functionality UI/UX wise. Maybe what I suggested is not the best approach.
Hi, @allanday, I know you are quite busy, but would you be able to suggest a way how to best integrate this functionality?
Possible options are:
- As I suggested before, replace "Cancel" button with "Pause" when downloading, which will pause it and change the button to "Cancel" once paused. It will also make "Resume" button to appear on the right side.
- Keep "Cancel" button, but add a new option into the cancel dialog allowing you not to only cancel the whole process, but only pause it.
- Keep it as it is UI-wise, but once user confirms cancellation in the cancel dialog, do not return to the main page, but keep it on the same downloading page and make "Resume" or "Retry" button available to restart the process.
| @@ -137,6 +137,14 @@ void DownloadManager::cancel() | |||
| } | |||
| } | |||
|
|
|||
| void DownloadManager::stopDownload() | |||
There was a problem hiding this comment.
This basically duplicates DownloadManager::cancel()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #716