Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New signing process for windows builds #641

Open
humaton opened this issue Sep 13, 2023 · 4 comments
Open

New signing process for windows builds #641

humaton opened this issue Sep 13, 2023 · 4 comments
Labels

Comments

@humaton
Copy link
Contributor

humaton commented Sep 13, 2023

Hi,

thanks to changes in PKI Industry new requirement is to store code signing certs on FIPS compatible devices. This happened just before our certificate expired.

We have a couple of options for how to approach this but, we will need to change the build and sign process for Windows binaries.

1, keep the process more or less the same but some changes to the build scripts will be required to use the pkcs 11 library. I am not sure how to approach this solution my knowledge of compiled languages is limited.

2, move the Windows build and sign process to the AWS Windows instances, this will require some refactoring on the build side and new ansible roles in fedora-infra. I can help here with provisioning the machine and ansible changes. This will use MS sign tool

@grulja grulja added the Windows label Sep 13, 2023
@grulja
Copy link
Collaborator

grulja commented Sep 18, 2023

Honesly, I'm completely lost here.

Can we still use osslsigncode sign but just using pkcs11 instead?

@grulja
Copy link
Collaborator

grulja commented Oct 5, 2023

Reference for myself: Check what Podman Desktop is doing.

Link: https://github.com/containers/podman-desktop/tree/main/.github/workflows.

@grulja
Copy link
Collaborator

grulja commented Nov 1, 2023

People from Podman Desktop paid for their own certificates because it was not possible to make use of Fedora/RedHat certificates as there was no infrastructure for that.

It also look we are not alone with this problem, see ImageMagick discussion: ImageMagick/ImageMagick#6826

@Conan-Kudo
Copy link

Why is it we can't use our existing pesign infrastructure for this, just plug in a different set of certificates? EFI and EXE signing is the same process (mechanically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants