Update LinkDescriptionObject to remove redundant 'jsonSchema' property #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h 'schema' and 'jsonSchema' redundantly.
|
Quick question: since this would be backwards incompatible change, what does JSON Schema specification say about it? I think it makes sense to fix broken things, but I just want to be sure there are no unintended consequences. There is also the question of which version fix should go in; usually that'd be the next new minor version (2.9). but in this case I'd prefer 2.8(.4) if fix is safe enough. |
|
See https://tools.ietf.org/html/draft-zyp-json-schema-03#page-16 section 6.1.1.4.3. 'schema' is defined (and 'targetSchema' in 6.1.1.3) but 'jsonSchema' is not defined at all. The same in V4 too (http://json-schema.org/latest/json-schema-hypermedia.html#anchor38). |
|
@tapina Thank you. I'll merge the patch then; will be included in 2.8.4 |
cowtowncoder
added a commit
that referenced
this pull request
Sep 28, 2016
nealeu
added a commit
to cambridgeweblab/common-java
that referenced
this pull request
Nov 10, 2021
…hat we had on forks The last is the enum -> class issues that was rejected: cambridgeweblab/jackson-databind@54a988a Included are: FasterXML/jackson-module-jsonSchema#117 FasterXML/jackson-module-jsonSchema#112 FasterXML/jackson-module-jsonSchema@8aae855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be just 'schema'.