Improve SERIALIZE_IDENTIFIER_FOR_LAZY_NOT_LOADED_OBJECTS feature
#96
Conversation
- don't require session or mapping for ids mapped with property access - add a testcase - improve documentation
| @@ -194,4 +200,40 @@ protected Object findProxied(HibernateProxy proxy) | |||
| } | |||
| return init.getImplementation(); | |||
| } | |||
|
|
|||
| // Alas, hibernate offers no public api to access this information, so we must resort to ugly hacks ... | |||
There was a problem hiding this comment.
Would be nice to expand just slightly on logic for accessing information.
There was a problem hiding this comment.
What to you mean by "expand on logic"? (How can I document the absence of a suitable API? Should I list what I tried, and why that didn't work?)
There was a problem hiding this comment.
What I meant was just to explain what is being done; mention that there's no public API is fine, but explain what information, and for what reason. If that is covered in other parts that may be fine.
There's no need (IMO) to explain what else has been tried; just what the intent is.
|
I wish I knew more about Hibernate; but from description and code, I think it makes sense to go ahead. One note: it may take a bit longer for me to get merge this as I will be on vacation for next 10 days or so. But I'll handle this when I return. |
- don't require session or mapping for ids mapped with property access - add a testcase - improve documentation
|
Ok, should be ready to merge now. |
|
Is there a reason this hasn't been merged yet? Do you need anything else from me? |
|
@bedag-moo The only obstacle (but big one) is my lack of time -- I have a long queue of things to work on. This PR is on my list so I will get to it, but unfortunately progress is slow, and the top is typically for regression bugs. So, thank you for all the work, and I hope to get to this as soon as possible! |
cowtowncoder
changed the title
SERIALIZE_IDENTIFIER_FOR_LAZY_NOT_LOADED_OBJECTS feature
to no longer require session or mapping if ids are mapped with property access
This fixes #50 for identifier properties mapped with property rather than field access, and documents workarounds for anyone else.
Currently, this PR only updates the Hibernate4Module; I wanted to wait for your feedback before updating the Hibernate5Module. The Hibernate3Module was not be updated, because it does not support the feature.