Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes jackson-module-paranamer issue 5 problem with paranamer + PropertyNamingStrategy #379

Merged

Conversation

cpilsworth
Copy link
Contributor

...yNamingStrategy. Update the creator properties after renaming using PropertyNamingStrategy as per initial _renameProperties() call.

…er + PropertyNamingStrategy. Update the creator properties after renaming using PropertyNamingStrategy as per initial _renameProperties() call.
@cowtowncoder
Copy link
Member

Looks good -- I assume you ran full unit test suite with the patch? If so, will merge and also backport in 2.3.

cowtowncoder added a commit that referenced this pull request Jan 6, 2014
Fixes jackson-module-paranamer issue 5 problem with paranamer + PropertyNamingStrategy
@cowtowncoder cowtowncoder merged commit bbb05ec into FasterXML:master Jan 6, 2014
@cpilsworth
Copy link
Contributor Author

Full unit test was ran. I will issue a pull request for the paranamer / PropertyNamingStrategy issue on the module project shortly. I needed to update the jackson-paranamer project to remove the deprecated AnnotationIntrospector methods that have been removed recently and to update the reference to the HEAD version of jackson-databind. Shall I leave those changes out of the PR?

@cowtowncoder
Copy link
Member

Thanks again.

On 2.4; yeah, if you could do another PR I can merge that in -- I haven't really synced up all 2.4 pieces yet after refactoring/cleanup of core pieces, so help there would be appreciated.

Also: I merged the fix in 2.3 branch as well. There will probably eventually be 2.3.2 out before 2.4. I don't think I yet moved Paranamer module master to 2.4 yet.

@cpilsworth cpilsworth deleted the paranamer-naming-strategy branch January 6, 2014 21:43
@cpilsworth
Copy link
Contributor Author

Glad to help. I've added a PR for the 2.4 fixes to jackson-module-paranamer here: FasterXML/jackson-module-paranamer#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants