Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPX schema cannot contain its own semantic version #69

Open
ejfdickinson opened this issue Sep 4, 2024 · 1 comment
Open

BPX schema cannot contain its own semantic version #69

ejfdickinson opened this issue Sep 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ejfdickinson
Copy link
Collaborator

The BPX standard has semantic versioning (major.minor.patch), so the current version is 0.4.0. However, the ["Header"]["BPX"] field is constrained to float by the schema. 0.4.0 is not and cannot be a float. Therefore a valid BPX file cannot correctly state its own version.

@martinjrobins @rtimms Any suggestions for how to fix this?
@ejfdickinson ejfdickinson added the bug Something isn't working label Sep 4, 2024
@valentinsulzer
Copy link

Seems like it should just be changed to string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valentinsulzer @ejfdickinson