Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a specific supported equation set for SPMe #59

Open
ejfdickinson opened this issue Jun 19, 2024 · 1 comment
Open

Define a specific supported equation set for SPMe #59

ejfdickinson opened this issue Jun 19, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@ejfdickinson
Copy link
Collaborator

Add to the BPX standard a specifically defined equation set for "SPMe", within which the BPX parameters are used.

This will require some discussion on whether the PyBaMM implementation is appropriate, or if the canonical SPMe defined by Marquis 2019 should be used. See also pybamm-team/PyBaMM#4145

@ejfdickinson ejfdickinson added the documentation Improvements or additions to documentation label Jun 19, 2024
@valentinsulzer
Copy link

I would push towards using the PyBaMM implementation (with better documentation) as this is the more "practically accurate" version, compared to the "mathematically accurate" version from Marquis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants