Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend allowed operations in BPX functions #53

Open
ejfdickinson opened this issue May 28, 2024 · 0 comments
Open

Extend allowed operations in BPX functions #53

ejfdickinson opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ejfdickinson
Copy link
Collaborator

ejfdickinson commented May 28, 2024

The use of BPX is currently limited by the restrictive set of mathematical operations that are allowed in FloatFunctionTable inputs.

The schema currently supports the following operations: *, /, -, +, **, exp, tanh.

Here are some suggestions:

  • Allow > and < to support piecewise functions as sums, e.g.: (x < 0) * 1 + (x > 0) * 0.5.
  • Scope for alternative variable dependencies, such as non-Arrhenius temperature dependence for chosen parameters.
    • A reasonable goal would be that BPX should support the electrolyte parameterisation in Landesfeind-Gasteiger 2019, which is widely used in industry, in which the electrolyte parameters are expressed as general functions $f(c_\mathrm{e}, T)$.
  • Support for "MSMR" expressions to write OCP as an explicit inverse function $\theta_k(U_{k,m,\mathrm{ref}})$, which is implemented in PyBaMM as the MSMR model
@ejfdickinson ejfdickinson added the enhancement New feature or request label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant