Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Pydantic>2 #39

Closed
wants to merge 4 commits into from
Closed

Migrate to Pydantic>2 #39

wants to merge 4 commits into from

Conversation

arjxn-py
Copy link
Contributor

@arjxn-py arjxn-py commented Jul 11, 2023 •
edited
Loading

Attempts to fix #38
cc @agriyakhetarpal
Initially we were getting around 7 failures which are down to 3 in this PR

arjxn-py
arjxn-py commented Jul 11, 2023
View reviewed changes
tests/test_schema.py

# bpxobject = BPX()

adapter = TypeAdapter(dict[str, dict[str, float | str | dict[str, Any]]])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here @agriyakhetarpal & I were stuck trying to configure bpx object to be parsed in TypeAdapter.

@arjxn-py arjxn-py marked this pull request as draft October 5, 2023 19:40
@arjxn-py
Copy link
Contributor Author

arjxn-py commented Apr 4, 2024

Closing as #51 is WIP

@arjxn-py arjxn-py closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimms rtimms Awaiting requested review from rtimms

@martinjrobins martinjrobins Awaiting requested review from martinjrobins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Pydantic>2
1 participant
@arjxn-py