Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package size reduction, it's currently 871 KB #45

Open
madrussa opened this issue Oct 7, 2019 · 0 comments
Open

Package size reduction, it's currently 871 KB #45

madrussa opened this issue Oct 7, 2019 · 0 comments

Comments

@madrussa
Copy link

madrussa commented Oct 7, 2019

I was amazed to find that adding rrule generator to our library added over 850kb to the build size of our application. Considering the library folder only contains 258kb of code the overall larger size was a shock.

The vast majority of which looks to be the moment locale files. Importing moment/locale/all accounts for over 380kb (See https://github.com/moment/moment/blob/develop/min/locales.js). Moment is a popular library and is likely already included in many projects. It would make sense to give users to ability to include the localisation support they require instead of bundling them all. Perhaps moving moment to a peer dependancy would reduce the size of this library and providing documentation on how to support more locales would improve usage and reduce file size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant