-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1/politicianheader #3
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a clean up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With clean up are you referring to line 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide more details on the BlurDataUrl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated a base64 version of the Placeholder image, so when loading it displays it. If there is a way to make it shorter, or want to remove it -- let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments below the files.
As this is your first PR it is normal that there are more comments and requests from my side. Please don't feel discouraged from it and continue the great work!
…and input validation.
FAIL test/app/components/Search.test.tsx (8.28 s)
Search
✓ should render the search input (38 ms)
✕ submits the search form with the search value entered by the user (188 ms)
● Search › submits the search form with the search value entered by the user