Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: BANKACCTFROM.ACCTTYPE property missing and typo #27

Closed
lkasvr opened this issue Dec 17, 2024 · 0 comments
Closed

BUG: BANKACCTFROM.ACCTTYPE property missing and typo #27

lkasvr opened this issue Dec 17, 2024 · 0 comments
Assignees

Comments

@lkasvr
Copy link

lkasvr commented Dec 17, 2024

Describe the bug
The bug happened when I tried to access the BANKACCTFROM.ACCTT property, which has the value undefined. After checking some OFX files, I realized the <ACCTT> tag is missing, but the <ACCTTYPE> tag is there. I also checked OFX Banking Specification v2.3.pdf, where there is a reference to the last tag mentioned, which can be found on page 602.

However, I can't say whether the <ACCTT> tag really isn't in any other specification, as I haven't checked all the others. But I can certainly say that the new specification provides for the <ACCTTYPE> tag.

To Reproduce
The issue occurs after I instantiate the Ofx class with a file content in OFX that has the respective <ACCTTYPE> tag, then call the .getContent() method on the instance, and finally access the BANKACCTFROM.ACCTT property which gives undefined, either its interface does not have ACCTTYPE as property.

Another way to reproduce the error is to add the following test to the ofx.espec.ts file:

test('', () => {
    const { OFX } = ofx.getContent();
    expect(OFX.BANKMSGSRSV1.STMTTRNRS.STMTRS.BANKACCTFROM.ACCTT).toBe('CHECKING');
  });

And then type npm run test. As the example.ofx is used as the ofx file parsed by the method and its tag <ACCTTYPE> has the following content: CHECKING.

Expected behavior
What is expected is that the BANKACCTFROM interface provides access to the ACCTTYPE property and its contents.

Screenshots
image

Desktop:

  • OS: Fedora Linux 40 (Workstation Edition) | Kernel Version: Linux 6.11.10-200.fc40.x86_64
  • Browser Chrome
  • Version chrome(131.0.6778.85 (Official Build) (64-bit))

Additional context
It seems to me that the ACTT property was a typo, but I'm not sure, however I believe that support for the ACTTYPE property should be present, considering that every property has its corresponding tag with exactly its name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants