Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OreDictEntryManager update and delete buttons #68

Open
elifoster opened this issue Nov 9, 2018 · 4 comments
Open

OreDictEntryManager update and delete buttons #68

elifoster opened this issue Nov 9, 2018 · 4 comments

Comments

@elifoster
Copy link
Member

elifoster commented Nov 9, 2018

When you update the information of an OreDict, or delete an OreDict, in the OreDictEntryManager, the page updates but the old values are still shown.

@elifoster elifoster changed the title OreDictEntryManager OreDictEntryManager update and delete buttons Nov 9, 2018
@elifoster
Copy link
Member Author

This might not happen on MediaWiki 1.33. I am not reproducing it on my local test wiki. Will keep it open until we can confirm it on the production site (FTB Gamepedia).

@elifoster
Copy link
Member Author

elifoster commented Feb 3, 2024

Just updated an entry (sourceVegetableOil Kapok Tuft to Sunflower Seeds) on the live wiki, and it put me into a blank entry manager page, with the url /Special:OreDictEntryManager/11681?entry_id=11681&tag_name=sourceVegetableOil&item_name=Sunflower+Seeds&mod_name=TVO&grid_params=&token=_redacted_&update=1. I think it really should just refresh the edit page. As for deleting, I'm not sure if it should take you to a blank entry manager page or to the OreDictList. Thoughts?

Granted, the Fandom fork is on the live wiki, not our own. I will test on my local test wiki.

@elifoster
Copy link
Member Author

Upon further investigation, it appears the edit did not take place at all, so the Fandom fork really just doesn't work and cannot be used to test any bugs or change requests on this issue tracker. Incredible.

@elifoster
Copy link
Member Author

Tested a delete and an edit on my local test wiki. Delete takes you to an empty entry manager page, and edit properly shows the new values. I still think it might be a good idea to have delete take you to the oredictlist, but not 100% sure, so I'm leaving this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant