Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: RSR attempts to attack other players' quest targets #121

Open
Flavescent opened this issue Apr 21, 2024 · 4 comments
Open

Bug: RSR attempts to attack other players' quest targets #121

Flavescent opened this issue Apr 21, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Flavescent
Copy link

Sometimes RSR tries (and fails) to engage other players' quest targets, spamming commands and error messages as shown below. It would be more elegant to avoid such targets altogether.

image

@Rabalaba
Copy link
Contributor

In the ObjectHelper.cs we can look into if EventId.Type == EventHandlerType.QuestBattleDirector and then filter out targets by looking at if EventId.Id != Player->EventId.Id

@NostraThomas99
Copy link
Contributor

I can definitely add this, but modifying how targets are acquired is always tricky business. Can someone give me a scenario I can use to recreate this issue so I can make sure it gets tested thoroughly?

@Flavescent
Copy link
Author

It needs two players, one with RSR and another doing a combat guildleve nearby. I made the screenshot above when another player was fighting some Bonze monsters as part of a guildleve southeast of Mor Dhona.

@NostraThomas99
Copy link
Contributor

#125

I've implemented this in the above PR, but I'm hesitant to merge it until me (or someone else) can confirm it works as intended. I can confirm it doesn't break targeting normal enemies, but I'm not sure it's going to have the intended effect.

@LTS-FFXIV LTS-FFXIV added bug Something isn't working enhancement New feature or request labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants