Extract oauth error information and fail early if it exists #3266
Conversation
|
This is nice. Why not go one step further and map some technical known errors into actual valuable user errors. Ideas: |
|
Do we want to display that in the error details view? It may be nice also to have some of that information populate instead of the generic "If this error continues..." message. That would be nicer for users as I imagine not everyone reads the stack trace, though I dont know much work it would be to do this |
|
It's a question of confidence. Are we 100% sure that our extracted errors are really the error cause? I am not sure if there is ambiguity and we might still need the original stacktrace. |
|
How about we leave the stack trace for exactly whatever the error is with as much detail as possible, but we allow the generic message to change based on the cases you describe. For a start anyway We can also always leave in a general "If this does not resolve..." paragraph at the end for the specific cases |
…nto bugfix/#3257_improve_oauth_failures
…nto bugfix/#3257_improve_oauth_failures
|
Wasnt sure how I wanted to go about this Scopes: No CSRF: |
|
Only thing I would probably say is just if we can de URL encode the description when we print it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3266 +/- ##
=============================================
+ Coverage 58.40% 58.45% +0.04%
- Complexity 3900 3913 +13
=============================================
Files 574 574
Lines 19158 19163 +5
Branches 1020 1025 +5
=============================================
+ Hits 11190 11202 +12
+ Misses 7458 7455 -3
+ Partials 510 506 -4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Fix #3257
After deleting the CSRF cookie:
After explicitly denying the oauth authorization:
Logging in normally still works as expected