Time shown for replay uses the real game time instead of replay lenght

[RegalEagIe]

Is your feature request related to a problem? Please describe.
At one point, the time shown for the replay lists was changed from being the replay length to the real time of the game, to my frustration, as it was more unreliable than the replay length.

Describe the solution you'd like
I'd like for it to return to the previous function that it had: showing replay length instead of real time, as it was a more meaningful metric.

Describe alternatives you've considered
If the reason it was changed to real time was debated, I'd then suggest showing both times, as there should be space for it in the card, both next to each other, and having a different icon for the clock. It could also be a good indicator of replay quality, as I believe replays that have a high variation between the two are more prone to replay desyncs.

[micheljung]

Agreed; the real time has no meaning when watching a replay.

[sulikdan]

@Sheikah45 Do we have anyone for icons creation?
I would replace existing one duration-icon for a new real-duration-icon (globe with duration-icon) and then add
another entry for (another) a new game-duration-icon (pc icon with duration-icon ).

Was looking into code, It seems that there is tickDurationLabel that could be used, however it is not initialized every time. Is it related to some sort of lazy loading? Cos it doesnt make sense to me. Anyway is it fine to use this label? It comes from Replay.replayTicks, but I have no idea what is this refering to or what it is about...

[Sheikah45]

The tick duration is populated by the replay server while the real time duration is populated by the lobby server.

So the tick duration is not always present if the replay server hasn't finalized the replay yet.

[Sheikah45]

As far as icons we use the icomoon SVG generator which I think is detailed in the wiki.

Here is the link https://github.com/FAForever/downlords-faf-client/wiki/Adding-Icons.

[sulikdan]

Forgot to pass link,
anyway the issue should have been already solved - #3233
Added game time to real time ...