Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support size 0 boxes #407

Closed
eric opened this issue Jan 21, 2025 · 3 comments
Closed

Support size 0 boxes #407

eric opened this issue Jan 21, 2025 · 3 comments
Labels
wontfix This will not be worked on

Comments

@eric
Copy link
Contributor

eric commented Jan 21, 2025

I was trying to decode some of the sample videos from Apple and found that they rely on the box size of 0 to indicate reading through to the end of the file. Is this something that would be hard to implement?

@tobbee
Copy link
Collaborator

tobbee commented Jan 21, 2025

I have never seen that used in practice, but it is an old QuickTime heritage, so I suppose there may be some old samples lying around. I'd rather not support it, since there are many other things that have higher priority.

@tobbee
Copy link
Collaborator

tobbee commented Jan 21, 2025

Regarding the implementation complexity, I think it will hit quite hard to support zero size everywhere.

@tobbee tobbee added the wontfix This will not be worked on label Jan 28, 2025
@tobbee
Copy link
Collaborator

tobbee commented Jan 28, 2025

@eric I think there can be very strange error cases if we allow box size zero, since it means that all remaining bytes until the end of the file will be "swallowed" by that box. Just allowing a specific box to have size zero is more feasible, but requires a very early test when the header is parsed for all boxes. If there is a super-duper good reason to have a zero-size box, please reopen this or open a new issue for that particular case, and we can discuss if it is worth the effort.

@tobbee tobbee closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants