Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialplan needs to be more sophisticated #78

Open
vodik opened this issue Mar 17, 2018 · 0 comments
Open

Dialplan needs to be more sophisticated #78

vodik opened this issue Mar 17, 2018 · 0 comments

Comments

@vodik
Copy link
Contributor

vodik commented Mar 17, 2018

Currently, if the dialplan falls through, it returns a 501. But that strictly isn't correct.

For example, if the server implements SUBSCRIBE, but its gated behind a particular user, it should return 404 back, for example.

Maybe it even makes sense to just drop that and have a flat mapping of methods to callbacks and leave these kinds of decisions to the library users?

After all, I think a lot of this functionality could be nicely gated behind middleware.
ovv added a commit that referenced this issue Apr 19, 2018
@ovv
Rework dialplan
659f010 
Current dialplan was not correct and complicated. This rework
simplify it greatly and provide an easy way to do your own routing

I think it will be a nice place to put helpers for
authentifications.

No idea if that will provide any advantages over a flat mapping
of methods / middlewares

issue #78
@ovv ovv mentioned this issue Apr 19, 2018
Merged
ovv added a commit that referenced this issue Apr 20, 2018
@ovv
Rework dialplan
fa1b4b3 
Current dialplan was not correct and complicated. This rework
simplify it greatly and provide an easy way to do your own routing

I think it will be a nice place to put helpers for
authentifications.

No idea if that will provide any advantages over a flat mapping
of methods / middlewares

issue #78
ovv added a commit that referenced this issue Apr 20, 2018
@ovv
Dialplan custom (#106)
92eea1e 
Current dialplan was not correct and complicated. This rework
simplify it greatly and provide an easy way to do your own routing

I think it will be a nice place to put helpers for
authentifications.

No idea if that will provide any advantages over a flat mapping
of methods / middlewares

issue #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vodik