Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-22] [$250] [Chore] Bump react-native-reanimated to 3.16.1 #52024

Closed
blazejkustra opened this issue Nov 5, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@blazejkustra
Copy link
Contributor

blazejkustra commented Nov 5, 2024

This issue aims to update react-native-reaniamted to the newest version because of two reasons:

  1. Workletization of react-native-live-markdown, requires that we have latest version installed + it blocks [Autocomplete] Highlight autocomplete key and selected value
  2. Starting from this versions, there is a new API for shared values that is compatible with react-compiler. More info here
Issue OwnerCurrent Issue Owner: @OfstadC
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853942849461570206
  • Upwork Job ID: 1853942849461570206
  • Last Price Increase: 2024-11-05
@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@blazejkustra blazejkustra changed the title Bump react-native-reanimated to 3.16.1 [Chore] Bump react-native-reanimated to 3.16.1 Nov 5, 2024
@Julesssss
Copy link
Contributor

Hey @blazejkustra. FYI, to prevent the crash from blocking us on staging we did a minor bump here today.

@luacmartins luacmartins self-assigned this Nov 5, 2024
@luacmartins
Copy link
Contributor

Assigning myself since this change affects Search - #50949

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Nov 5, 2024
@melvin-bot melvin-bot bot changed the title [Chore] Bump react-native-reanimated to 3.16.1 [$250] [Chore] Bump react-native-reanimated to 3.16.1 Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021853942849461570206

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@blazejkustra
Copy link
Contributor Author

blazejkustra commented Nov 6, 2024

Update: I created a draft PR with the update, however I hit a wall because there are crashes after the upgrade, I let the reanimated team know and they are working on it (here is an upstream issue).

Also FYI I'm OOO 7-11 November, so I'll come back to this after the break.

@luacmartins
Copy link
Contributor

Thanks for the update @blazejkustra! Enjoy your time off.

Copy link

melvin-bot bot commented Nov 11, 2024

@eVoloshchak, @Julesssss, @OfstadC, @luacmartins, @blazejkustra Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Nov 12, 2024
@blazejkustra
Copy link
Contributor Author

Update: PR that bumps the version is ready and awaits C+ review.

however I hit a wall because there are crashes after the upgrade, I let the reanimated team know and they are working on it (software-mansion/react-native-reanimated#6613 is an upstream issue).

We decided not to wait for the upstream fixes as this could take more time than initially anticipated, and new version is crucial as it affects Search - #50949.

Once the above PR is merged let's not close this issue so we can migrate to new shared values API as part of this issue, wdyt @luacmartins?

@luacmartins
Copy link
Contributor

Sounds good!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 15, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Chore] Bump react-native-reanimated to 3.16.1 [HOLD for payment 2024-11-22] [$250] [Chore] Bump react-native-reanimated to 3.16.1 Nov 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 15, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 15, 2024

@eVoloshchak @OfstadC @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants