[HOLD for payment 2024-11-18] Reports with "report not found" error cause Inbox tab RBR

[puneetlath]

Reports that have the "Report not found" error in Onyx are not shown in the LHN. But they do cause an RBR to be shown on the Inbox tab. We should align the RBR behavior on the Inbox tab with reports that are shown in the LHN. If a report isn't shown in the LHN, it should never trigger an RBR/GBR on the tab.

cc @pac-guerreiro

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[DylanDylann]

From #51425 (comment), On LHN, we use useReportIDs hook to filter and sort reports first

App/src/pages/home/sidebar/SidebarLinksData.tsx

Line 40 in 2463bf7

const {orderedReportIDs, currentReportID, policyMemberAccountIDs} = useReportIDs();

I think we should apply the logic in useReportIDs into getChatTabBrickRoadReport to make it consistent

[pac-guerreiro]

@DylanDylann Thanks for the help here!

@puneetlath PR is ready to be reviewed

[pac-guerreiro]

@puneetlath today I applied @DylanDylann suggestions to the PR

[pac-guerreiro]

@puneetlath The PR is ready to be merged! Thanks @DylanDylann 😄

[pac-guerreiro]

@puneetlath the PR is waiting to be merged

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[pac-guerreiro]

The PR is finally merged 🎉 Thanks @puneetlath 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Reports with "report not found" error cause Inbox tab RBR #51675

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @puneetlath The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

The regression test is included here. So we don't need the checklist here anymore