Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] Make all chats visible in New Supportal with all Add_Comment actions redacted #51221

Open
VictoriaExpensify opened this issue Oct 22, 2024 · 12 comments
Assignees
Labels
High Priority Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@VictoriaExpensify
Copy link
Contributor

VictoriaExpensify commented Oct 22, 2024

Background
Concierge Responders use New Supportal to provide customer support and troubleshooting; our Sales team also uses it to give demos and onboard customers. Because of that, it's important these teams can see the information needed to support customers.

Problem
We redacted New Expensify chats from view in Supportal earlier in the year in order to protect our customers privacy. In doing so, some of the information needed to successfully troubleshoot and demo to customers has also been revoked.

Solution
As discussed here, we want to update New Expensify chat visibility in Supportal to allow the following:

  • Make all will make all chat previews visible in the LHN, regardless of type
  • When a chat is clicked into, the message content will be redacted but relevant information, such as expenses and actions taken (e.g something being approved or exported) will be visible
  • The #admins channels will be visible in their entirety as they contain an audit-trail for the Workspace which is required for troubleshooting
@VictoriaExpensify VictoriaExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@VictoriaExpensify VictoriaExpensify added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @blimpich (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 22, 2024
@VictoriaExpensify VictoriaExpensify added the Internal Requires API changes or must be handled by Expensify staff label Oct 22, 2024
@blimpich blimpich removed the Daily KSv2 label Oct 22, 2024
@VictoriaExpensify VictoriaExpensify removed the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Oct 22, 2024
@VictoriaExpensify VictoriaExpensify added Hot Pick Ready for an engineer to pick up and run with High Priority labels Oct 22, 2024
@maddylewis maddylewis moved this to Support (HIGH) in [whatsnext] #retain Oct 23, 2024
@VictoriaExpensify VictoriaExpensify changed the title Update New Supportal to include chat details [HIGH] Update New Supportal to include chat details Oct 25, 2024
@maddylewis maddylewis added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 29, 2024
@VictoriaExpensify VictoriaExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Current assignee @muttmuure is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Oct 29, 2024
@VictoriaExpensify
Copy link
Contributor Author

This should be a New Feature, not a Bug

@marcaaron
Copy link
Contributor

Is this issue still necessary if we stop redacting the chats themselves and start redacting the messages instead? 🤔

@VictoriaExpensify
Copy link
Contributor Author

I think so @marcaaron , because the chats still need to be visible in the LHN for us to redact the messages. At the moment, they are not. Having redacted messages isn't going to be helpful if we can't see the chats in the first place. Here's an example:

Supportal:
image

Actual account:
image

@maddylewis maddylewis moved this from Support (HIGH) to Product (CRITICAL) in [whatsnext] #retain Nov 6, 2024
@maddylewis maddylewis changed the title [HIGH] Update New Supportal to include chat details [CRITICAL] Update New Supportal to include chat details Nov 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@VictoriaExpensify
Copy link
Contributor Author

VictoriaExpensify commented Nov 12, 2024

Posted a few questions to #Retain for discussion, these are the agreed outcomes on how the design should look:

Since the chat previews show a preview of the actual chat, how should this look if it’s redacted?
We should show either "Redacted" or "XXXX" to show where the redacted information was e.g.:

image

When the chat is clicked into, what should we see in place of the redacted messages?
Same as above, we should show "Redacted" or "XXXX" e.g.:
image

What “relevant” information should be included?
To start, we should redact any ADD_COMMENT actions and show anything that is not an ADD_COMMENT action

@marcaaron - is this enough information to help you get started on this? Let me know if there's any other info that would be useful

@maddylewis maddylewis moved this from Product (CRITICAL) to Hot Picks in [whatsnext] #retain Nov 12, 2024
@marcaaron
Copy link
Contributor

Yes, looks good. Let's update the Issue description with the new details? I can get started on this tomorrow.

@marcaaron marcaaron self-assigned this Nov 13, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2024
@VictoriaExpensify VictoriaExpensify changed the title [CRITICAL] Update New Supportal to include chat details [CRITICAL] Make all chats visible in New Supportal with all Add_Comment actions redacted Nov 13, 2024
@trjExpensify trjExpensify removed the Hot Pick Ready for an engineer to pick up and run with label Nov 13, 2024
@marcaaron
Copy link
Contributor

Made some progress on this one today. We are returning these messages via various different paths... it could take some time to track down all of it. e.g. the search APIs also return some reports with chats. some of it resides in Auth and some of it in Web AFAICT.

@VictoriaExpensify
Copy link
Contributor Author

If there is anything I can do to help with the hunt, let me know @marcaaron

@maddylewis maddylewis moved this from Hot Picks to Product (CRITICAL) in [whatsnext] #retain Nov 14, 2024
@marcaaron
Copy link
Contributor

Almost wrapped on this one. Seems like ReconnectApp and pusher updates are not accessible by supportal so no need to worry about these flows.

@marcaaron marcaaron added the Reviewing Has a PR in review label Nov 15, 2024
@marcaaron
Copy link
Contributor

Put this into review today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Product (CRITICAL)
Development

No branches or pull requests

6 participants