Review duplicates - Review duplicates button does not disappear after the expense is paid

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Submit an expense to the workspace chat.
4. Pay the expense.
5. Submit the same expense in Step 3 to the workspace chat.
6. Click on the expense preview.
7. Click Pay elsewhere and pay it.

Expected Result:

Review duplicates button will disappear after the expense is paid.

Actual Result:

Review duplicates button does not disappear after the expense is paid. It only disappears after the page is refreshed.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6640180_1729422842946.20241020_184629.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @marcochavezf

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[Shahidullah-Muffakir]

Related PR #50133

[daledah]

This is likely a BE Bug, as PayMoneyRequest doesn't remove transactionViolations in Onyx:

We can add optimistic data to remove transactionViolations from the FE side, but I think we should apply the same change to BE as well.

[adelekennedy]

this is high priority but imo shouldn't delay deploys etc - @marcochavezf if you disagree!

[marcochavezf]

Yup, sounds good, it shouldn't be a deploy blocker and I agree this should be fixed in the BE

[adelekennedy]

@marcochavezf con contributors help here at all or is this an entirely BE issue you're working on?

[marcochavezf]

I think this is entirely BE, I'm fixing another priority bug, I will come back to this one tomorrow

[melvin-bot]

@marcochavezf, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

Continuing with investigation today

[marcochavezf]

I asked internally what would be the better solution in the BE

[marcochavezf]

PR in review for BE fix

[marcochavezf]

I quickly created a PR for the optimistic values. It's on hold for the BE fix.

[allgandalf]

Please assign me here for payment, I will be reviewing the attached PR #51770