Android – Sign in Hibrid app – Wellcome modal appears if transition from HybridApp to NewDot

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #49960

Action Performed:

1. Go to staging NewDot app
2. Log in with a new Gmail account and finish the onboarding
3. Login on HybridApp with the same account
4. Click on Try New Expensify in LHN for transition from OldDot to NewDot

Expected Result:

Wellcome to Expensify modal is not shown

Actual Result:

Wellcome to Expensify modal appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6621806_1727839809153.1A_Refactor_NewDot_and_HybridApp_onboarding_flow.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @srikarparsi

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[isogit123]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The welcome modal appears when transitioning from HybridApp to NewDot.

What is the root cause of that problem?

The onboarding flow is explicitly set to be shown when transitioning to NewDot if the OldDot onboarding is completed but the NewDot onboarding is not here:

App/src/hooks/useOnboardingFlow.ts

Lines 35 to 39 in 99f280b

	// But if the hybrid app onboarding is completed, but NewDot onboarding is not completed, we start NewDot onboarding flow
	// This is a special case when user created an account from NewDot without finishing the onboarding flow and then logged in from OldDot
	if (isHybridAppOnboardingCompleted === true && isOnboardingCompleted === false) {
	OnboardingFlow.startOnboardingFlow();
	}

What changes do you think we should make in order to solve the problem?

Remove the code mentioned above to disable this behavior.

What alternative solutions did you explore? (Optional)

[ishpaul777]

will review today

[dylanexpensify]

TY @ishpaul777!

[ishpaul777]

Reviewing the related code it looks expected 🤔 and not a bug.

@dylanexpensify Can you please help confirm expected behaviour internally ?

[melvin-bot]

@dylanexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ishpaul777]

gentle bump @dylanexpensify ^

[melvin-bot]

@dylanexpensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@dylanexpensify, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[ishpaul777]

not overdue this looks expected from the code.

[ishpaul777]

🎀 👀 🎀 C+ reviewed

Pulling a internal engineer for help ( @srikarparsi It looks like it is expected from these LOCs)

App/src/hooks/useOnboardingFlow.ts

Lines 35 to 39 in 99f280b

	// But if the hybrid app onboarding is completed, but NewDot onboarding is not completed, we start NewDot onboarding flow
	// This is a special case when user created an account from NewDot without finishing the onboarding flow and then logged in from OldDot
	if (isHybridAppOnboardingCompleted === true && isOnboardingCompleted === false) {
	OnboardingFlow.startOnboardingFlow();
	}

will you please close this or let us know if want to fix this

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Hey @kadiealexander! I'm heading out on parental leave so reassigning this! TY!

[melvin-bot]

@srikarparsi, @kadiealexander, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[srikarparsi]

Yes agreed @ishpaul777, the onboarding flow was not completed in the video and that's why the onboarding flow re-opened as you explained. Going to close this one out.