[HOLD for payment 2024-10-14] [$250] Sign in–Magic code expired appears briefly if use Request one here link & login via magic link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4886771
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. On the log in screen, enter a new account email
3. Repeat the previous step with the same email - This is to receive 2 validation links
4. Navigate to the account email inbox and open the first email of the 2
5. Copy the magic link and change it to staging
6. Navigate to the staging link
7. Verify Magic code expired page opens
8. Click on Request one here link
9. Navigate to the account email inbox and open the email
10. Copy the magic link, change it to staging and navigate to the staging link

Expected Result:

Magic code expired not appears briefly

Actual Result:

Magic code expired appears briefly

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6579619_1724356216934.MC.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ba582e21228c322
• Upwork Job ID: 1828311848767754708
• Last Price Increase: 2024-09-10

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Amoralchik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user sees the ValidateCodeModal instead of a loading screen when accessing the magic link.

What is the root cause of that problem?

Here in ValidateLoginPage:

App/src/pages/ValidateLoginPage/index.website.tsx

Line 77 in 844c6bf

{(!session?.autoAuthState ? !shouldStartSignInWithValidateCode : autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED) && !exitTo && (

This condition returns true even when shouldStartSignInWithValidateCode is true. This caused the ValidateCodeModal to be shown to the user.

What changes do you think we should make in order to solve the problem?

By changing the condition to
!shouldStartSignInWithValidateCode && autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && !exitTo
By this we can prevent the display ValidateCodeModal, and we can display the Loading Indicator instead of the ValidateCodeModal including it in the condition for FullScreenLoadingIndicator.
I suggest making the changes as follows:

    // If session.autoAuthState isn't available yet, we use shouldStartSignInWithValidateCode to conditionally render the component instead of local autoAuthState which contains a default value of NOT_STARTED
    const shouldValidateModal = !shouldStartSignInWithValidateCode && autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && !exitTo;
    const isFailed = autoAuthState === CONST.AUTO_AUTH_STATE.FAILED;
    const isJustSignedIn2FA = autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN && is2FARequired && !isSignedIn && login;
    const isJustSignedIn = autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN && isSignedIn && !exitTo && login;

    return (
        <>
            {isFailed && <ExpiredValidateCodeModal />}
            {isJustSignedIn2FA && <JustSignedInModal is2FARequired />}
            {isJustSignedIn && <JustSignedInModal is2FARequired={false} />}
            {shouldValidateModal && (
                <ValidateCodeModal
                    accountID={Number(accountID)}
                    code={validateCode}
                />
            )}
            {!shouldValidateModal && !isJustSignedIn && !isJustSignedIn2FA && <FullScreenLoadingIndicator />}
        </>
    );

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ba582e21228c322

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[greg-schroeder]

Looks like we have one proposal to review when you get a chance, Rajat!

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The magic code expired is shown briefly when open the magic link for the 2nd time.

What is the root cause of that problem?

When we open the expired magic link for the first time, the session.autoAuthState is FAILED. When we reopen the 2nd magic link, the state is still the same, FAILED, so the magic code expired view is shown briefly.

App/src/pages/ValidateLoginPage/index.website.tsx

Line 73 in d5cfecf

{autoAuthState === CONST.AUTO_AUTH_STATE.FAILED && <ExpiredValidateCodeModal />}

What changes do you think we should make in order to solve the problem?

I suggest that we clear the autoAuthState when pressing the request one here text,

App/src/components/ValidateCode/ExpiredValidateCodeModal.tsx

Lines 38 to 45 in d5cfecf

	<TextLink
	onPress={() => {
	Session.beginSignIn(credentials?.login ?? '');
	Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
	}}
	>
	{translate('validateCodeModal.requestOneHere')}
	</TextLink>

function clearAutoAuthState() {
    Onyx.merge(ONYXKEYS.SESSION, {autoAuthState: null});
}
...
onPress={() => {
    Session.clearAutoAuthState();
    ...
})

[parasharrajat]

Checking...

[melvin-bot]

@parasharrajat, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[parasharrajat]

Couldn't spend much time testing this bug on Friday. Going to look more in the bug before picking up a proposal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@parasharrajat @greg-schroeder this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

Let me know how you go @parasharrajat!

[melvin-bot]

@parasharrajat, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

I will check this tomorrow.

[greg-schroeder]

Thanks for the update @fabioh8010! Looks like @MonilBhavsar you're back up for a new review <3

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to v2.0.71 #49857

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix magic code expired is shown briefly #49042

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Payment summary:

Contributor: @bernhardoj - $250 - Can make a manual request via ND to be paid on 10/14
C+: @parasharrajat - $250 - Can make a manual request via ND to be paid on 10/14

[bernhardoj]

Requested in ND.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Error modal when signin from expired magic link #15505
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Error modal when signin from expired magic link #15505 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Log out from the app
2. Enter your login once
3. Go back
4. Enter your login again. Verify you receive 2 magic code & link emails
5. Open the first email magic link
6. Verify a magic code expired is shown
7. Open the second email magic link
8. Verify a magic code expired isn't shown briefly

Do you agree 👍 or 👎 ?

[greg-schroeder]

Oops - regression period is actually 10/14 because the 10/11 date is for the Onyx bump PR, not the PR that fixes this. Updated

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1828311848767754708/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

All right, these manual requests can be approved per #47883 (comment)

[greg-schroeder]

Adding regression test, closing!

[JmillsExpensify]

$250 approved for @bernhardoj