-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description #46486
Comments
Triggered auto assignment to @slafortune ( |
Triggered auto assignment to @Julesssss ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think this issue might be related to the #collect project. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Room description system message shows code when adding emoji and text with mark down to room description. What is the root cause of that problem?We did not cover the case of description being HTML, we just render plain text: App/src/libs/ReportActionsUtils.ts Line 1588 in 3418820
App/src/pages/home/report/ReportActionItem.tsx Lines 649 to 651 in 7ae492e
What changes do you think we should make in order to solve the problem?Add a new prop to if (shouldRenderHtml) {
return (
<View>
<RenderHTML html={`<comment><muted-text>${message}</muted-text></comment>`} />
</View>
)
} Toggle App/src/pages/home/report/ReportActionItem.tsx Lines 649 to 651 in 7ae492e
|
I don't see any changes to the API or Auth command in the last 3 months, so I'm leaning towards App. I see some potential PRs that may have caused the regression: |
Not a blocker, updating room names is not worth holding the release |
@Julesssss Update room description system message was added in #45986. It's the offending PR as explained in my proposal. |
Thanks @gijoe0295. We haven't got to the proposal stage yet, but we can compensate if this solution is used. I am asking the author to fix with a follow-up PR. |
@Julesssss I will raise a PR soon. |
@hungvu193 @Julesssss we have a follow PR here |
PR merged |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-09. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
Fixed internally - closing |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
Room description system message will not show code when adding emoji and text with mark down to room description.
Actual Result:
Room description system message shows code when adding emoji and text with mark down to room description.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6556785_1722292620046.20240730_063624.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @slafortuneThe text was updated successfully, but these errors were encountered: