Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description #46486

Closed
6 tasks done
izarutskaya opened this issue Jul 30, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to a room.
  3. Click on the room header.
  4. Click Room description.
  5. Enter an emoji, text with mark down and save it.
  6. Go back to room chat.

Expected Result:

Room description system message will not show code when adding emoji and text with mark down to room description.

Actual Result:

Room description system message shows code when adding emoji and text with mark down to room description.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6556785_1722292620046.20240730_063624.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 30, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@gijoe0295
Copy link
Contributor

gijoe0295 commented Jul 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room description system message shows code when adding emoji and text with mark down to room description.

What is the root cause of that problem?

We did not cover the case of description being HTML, we just render plain text:

return `${Localize.translateLocal('roomChangeLog.updateRoomDescription')} ${originalMessage?.description}`;

} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
const message = ReportActionsUtils.getUpdateRoomDescriptionMessage(action);
children = <ReportActionItemBasicMessage message={message} />;

What changes do you think we should make in order to solve the problem?

Add a new prop to ReportActionItemMessage: shouldRenderHTML where if it is, return RenderHTML:

if (shouldRenderHtml) {
    return (
        <View>
            <RenderHTML html={`<comment><muted-text>${message}</muted-text></comment>`} />
        </View>
    )
}

Toggle shouldRenderHTML for update room description report action:

} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
const message = ReportActionsUtils.getUpdateRoomDescriptionMessage(action);
children = <ReportActionItemBasicMessage message={message} />;

@Julesssss
Copy link
Contributor

I don't see any changes to the API or Auth command in the last 3 months, so I'm leaning towards App. I see some potential PRs that may have caused the regression:

@Julesssss
Copy link
Contributor

Not a blocker, updating room names is not worth holding the release

@gijoe0295
Copy link
Contributor

gijoe0295 commented Jul 30, 2024

@Julesssss Update room description system message was added in #45986. It's the offending PR as explained in my proposal.

@Julesssss
Copy link
Contributor

Thanks @gijoe0295. We haven't got to the proposal stage yet, but we can compensate if this solution is used. I am asking the author to fix with a follow-up PR.

@nkdengineer
Copy link
Contributor

@Julesssss I will raise a PR soon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 30, 2024
@nkdengineer
Copy link
Contributor

@hungvu193 @Julesssss we have a follow PR here

@Julesssss
Copy link
Contributor

PR merged

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 2, 2024
@melvin-bot melvin-bot bot changed the title Room - System message shows code when adding emoji and mark down to room description [HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description Aug 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

Copy link

melvin-bot bot commented Aug 2, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Julesssss] The PR that introduced the bug has been identified. Link to the PR:
  • [@Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Julesssss] Determine if we should create a regression test for this bug.
  • [@Julesssss] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@slafortune
Copy link
Contributor

Fixed internally - closing

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants