Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-10] [LOW] [Performance] Improve the TTI for native apps #43746

Closed
mountiny opened this issue Jun 14, 2024 · 30 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jun 14, 2024

Coming from here

Problem

The TTI time for Android app using the heavy account is 60s. For iOS App its 16s. This would deter any user from using the App as they would not wait that long for it to start being usable

Solution

Investigate how we can speed up the start up time for native devices

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jun 14, 2024
@mountiny mountiny self-assigned this Jun 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Copy link

melvin-bot bot commented Jun 14, 2024

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jun 14, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hurali97
Copy link
Contributor

@mountiny Please assign this to me 👋

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 14, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

@JmillsExpensify, @mountiny, @abdulrahuman5196, @hurali97 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@mountiny
Copy link
Contributor Author

@hurali97 what are the next steps?

@JmillsExpensify
Copy link

Still waiting for clarity on next steps

Copy link

melvin-bot bot commented Jun 19, 2024

@JmillsExpensify, @mountiny, @abdulrahuman5196, @hurali97 Huh... This is 4 days overdue. Who can take care of this?

@mountiny
Copy link
Contributor Author

@hurali97 is working on this one

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Jun 21, 2024
@abdulrahuman5196
Copy link
Contributor

Hi Team, I have limited availability to work on issues currently, so unassigning myself to avoid further delays and reproritize. Kindly add another C+.
@mountiny

@abdulrahuman5196 abdulrahuman5196 removed their assignment Jun 24, 2024
@mountiny
Copy link
Contributor Author

@hungvu193 is taking one

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [LOW] [Performance] Improve the TTI for native apps [HOLD for payment 2024-07-10] [LOW] [Performance] Improve the TTI for native apps Jul 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @hurali97 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
  • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hungvu193] Determine if we should create a regression test for this bug.
  • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@hoangzinh
Copy link
Contributor

@mountiny can you help assign me to this issue so that we can handle payment here when everything is done with @hungvu193 ? I helped to review the Onyx PR Expensify/react-native-onyx#563

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Payment Summary

Upwork Job

  • ROLE: @hoangzinh paid $500 via Upwork
  • Reviewer: @hungvu193 owed $500 via NewDot
  • Contributor: @hurali97 is from an agency-contributor and not due payment

BugZero Checklist (@JmillsExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mountiny
Copy link
Contributor Author

@hoangzinh @hungvu193 what is the payment summary on this one?

@hoangzinh
Copy link
Contributor

I recall the total is 1000$ https://expensify.slack.com/archives/C02NK2DQWUX/p1719302159058329?thread_ts=1719301209.052599&cid=C02NK2DQWUX. 500$ for each person, what do you think? 🤔

@JmillsExpensify
Copy link

@mountiny Can you provide a payment summary confirming that you agree?

@mountiny
Copy link
Contributor Author

Yes that sounds good to me, thank you for you quick help on this tricky task

@hungvu193 $500
@hoangzinh $500

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

@JmillsExpensify, @hoangzinh, @hungvu193, @mountiny, @hurali97 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-10] [LOW] [Performance] Improve the TTI for native apps [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-10] [LOW] [Performance] Improve the TTI for native apps Jul 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)
  • @hungvu193 requires payment through NewDot Manual Requests
  • @hurali97 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh / @hungvu193] The PR that introduced the bug has been identified. Link to the PR:
  • [@hoangzinh / @hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hoangzinh / @hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hoangzinh / @hungvu193] Determine if we should create a regression test for this bug.
  • [@hoangzinh / @hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@JmillsExpensify
Copy link

@hoangzinh offer sent via Upwork. @hungvu193 feel free to submit a request via NewDot.

@hoangzinh
Copy link
Contributor

Accepted. Thanks @JmillsExpensify

@hungvu193
Copy link
Contributor

Thanks. I'll request on NewDot later.

@JmillsExpensify
Copy link

Awesome. I've paid out the Upwork contract so we can circle back on your payment when I process in New Expensify.

@JmillsExpensify
Copy link

JmillsExpensify commented Jul 19, 2024

$500 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants