Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs already deployed to production included on staging checklist, PRs incorrectly commented on #23368

Closed
jasperhuangg opened this issue Jul 21, 2023 · 8 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jul 21, 2023

As a result of this actions run: https://github.com/Expensify/App/actions/runs/5625378789

A few PRs that were already deployed to production were commented on as "deployed to staging" (e.g. #23085)

Screenshot 2023-07-21 at 1 23 55 PM

I also saw a PR that was reverted was commented on as "deployed to staging" incorrectly.

All of these PRs were duplicated in the new staging deploy checklist that was generated.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ae2cbe68255df19f
  • Upwork Job ID: 1685051183088631808
  • Last Price Increase: 2023-07-28
@jasperhuangg jasperhuangg added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@jasperhuangg jasperhuangg added Weekly KSv2 and removed Daily KSv2 labels Jul 21, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stephanieelliott
Copy link
Contributor

@jasperhuangg this seems like something we would need to fix internally, yeah?

@jasperhuangg jasperhuangg added Engineering Improvement Item broken or needs improvement. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@stephanieelliott stephanieelliott added the Internal Requires API changes or must be handled by Expensify staff label Jul 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ae2cbe68255df19f

@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@rushatgabhane rushatgabhane removed their assignment Jul 29, 2023
@Beamanator
Copy link
Contributor

FYI this happened again today

Discussed a bit in slack here on how to organize those PRs from previous checklists that are already deployed to production

@roryabraham
Copy link
Contributor

Closing this as a dupe of #4379

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants