[HOLD for payment 2023-09-06] [$2000] Dev: Web - Console error on click of Next button in 2FA

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Security > Two-factor authentication
2. Click on copy button and click on Next button
3. Scan the qr code in authenticator app
4. Enter six digit code
5. Click on Next button

Expected Result:

It should not show any console error

Actual Result:

Console error appears (Failed prop type: Invalid prop forwardedRef supplied to withOnyx(Component).)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-14.at.3.20.08.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689328521600739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d58d7cdae12240f0
• Upwork Job ID: 1684614195949875200
• Last Price Increase: 2023-08-08
• Automatic offers:
• aimane-chnaif | Reviewer | 26032740
• kushu7 | Contributor | 26032742
• gadhiyamanan | Reporter | 26032744
• tienifr | Contributor | 26054370

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Dupe of #22922

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[muttmuure]

Closing dupe

[gadhiyamanan]

@muttmuure we can close the other issue and reopen this issue because this issue reported first in Slack

[gadhiyamanan]

@muttmuure #22922 was closed, we can reopen this issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d58d7cdae12240f0

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@muttmuure @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Upwork job price has been updated to $2000

[muttmuure]

Not overdue

[getusha]

Unable to reproduce on staging.

[studentofcoding]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

1. Go to Settings > Security > Two-factor authentication
2. Click on copy button and click on Next button
3. Scan the qr code in authenticator app
4. Enter six digit code
5. Click on Next button

Expected Result:

It should not show any console error

Actual Result:

Console error appears (Failed prop type: Invalid prop forwardedRef supplied to withOnyx(Component).)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-14.at.3.20.08.PM.mov
Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689328521600739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

OOT, how to run https://new.expensify.com/ on local? because when I run npm run web the ones opened is another link and my URL is localhost:9000 not localhost:8080 that you have

cc: @gadhiyamanan

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-08-10 17:15:16 Z
• when the PR got merged: 2023-08-25 14:58:02 UTC
• days elapsed: 10

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/22929 forwardref console error #24405

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @kushu7 requires payment offer (Contributor)
• @aimane-chnaif requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@kushu7, @muttmuure, @aimane-chnaif, @hayata-suenaga, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[aimane-chnaif]

This is dev console error which doesn't affect production app. No need regression test.

[muttmuure]

@kushu7 - $2000 - C
@tienifr - $2000 - C
@gadhiyamanan - $250 - Reporter
@aimane-chnaif - $3000 - C+

[muttmuure]

Also paying @aimane-chnaif for the review

[muttmuure]

Everyone is paid via Upwork. Closing

[aimane-chnaif]

@muttmuure this might be eligible for urgency bonus. can you please check?

Timeline analysis:

• @kushu7 assigned: 2023-08-09 16:34 UTC
• @tienifr got assigned: 2023-08-10 17:15 UTC
• put hold: 2023-08-11 11:39 UTC
• remove hold: 2023-08-24 15:16 UTC
• PR got merged: 2023-08-25 14:58 UTC

Clocked:

• 08-09 16:34 ~ 08-11 11:39 (less than 2 days)
• 08-24 15:16 ~ 08-25 14:58 (less than a day)

Less than 3 days total

[kushu7]

Less than 3 days total

I also think that its eligible for urgency bonus. 🤔

[muttmuure]

@aimane-chnaif made a good point that the PR was shared work between @kushu7 and @tienifr.

The bounty should have been $3k between the two contributors, equalling $1.5k each. Since you've already been paid $2k for the work which is more than the bounty inclusive of urgency bonus, I will not be applying a further urgency bonus here.
Notwithstanding, thank you for your hard work!

I have added an urgency bonus to @aimane-chnaif's upwork contract as his work was done solo.