You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is problematic at present as it appears to map MyCompany.Domain.Cart to MyCompany_ItemAdded
While I'm not a fan of seeing the naming of events as a global thing in the first instance*, I feel that this code is worse than useless as you'll inevitably end up with multiple MyCompany_Added things if you start from this code, which will conceal the objective of the code
I'd be more than happy to make a PR to remove the prefixing logic, but would settle for any resolution that's more likely to end up with a useful convention as people inevitably paste this code around the world ;)
(for me, the event types should be relative to a Category and not even be subject to a global uniqueness constraint within a given store)
The text was updated successfully, but these errors were encountered:
The logic in
StreamNameMapper.ToStreamPrefix
:samples/CQRS_Flow/.NET/Core/Core/Events/StreamNameMapper.cs
Lines 23 to 27 in 285a717
is problematic at present as it appears to map
MyCompany.Domain.Cart
toMyCompany_ItemAdded
While I'm not a fan of seeing the naming of events as a global thing in the first instance*, I feel that this code is worse than useless as you'll inevitably end up with multiple
MyCompany_Added
things if you start from this code, which will conceal the objective of the codeI'd be more than happy to make a PR to remove the prefixing logic, but would settle for any resolution that's more likely to end up with a useful convention as people inevitably paste this code around the world ;)
The text was updated successfully, but these errors were encountered: