Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove derived implementations for private key types #694

Closed
mrain opened this issue Oct 24, 2024 · 1 comment · Fixed by #696
Closed

Remove derived implementations for private key types #694

mrain opened this issue Oct 24, 2024 · 1 comment · Fixed by #696
Assignees
@mrain

Comments

@mrain
Copy link
Contributor

mrain commented Oct 24, 2024

Zulip discussion thread: https://espresso.zulipchat.com/#narrow/channel/311646-Consensus/topic/private.20keys/near/478545916

Summary: remove derived Serialize, Debug and Display for private key types.
Implement Debug for them but only print *** or <private key> or something similar.
@mrain mrain self-assigned this Oct 24, 2024
@alxiong
Copy link
Contributor

alxiong commented Oct 28, 2024

we should also add from/to_bytes() on private keys.

@mrain mrain mentioned this issue Oct 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrain mrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove derived Debug and Serialize from private key types EspressoSystems/jellyfish
2 participants
@mrain @alxiong