-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use BigEndian for SolidityTranscript #619
Conversation
c516b79
to
f08c3d0
Compare
Somehow there's still one test failed after ce7cff8. after some digging, I'm unable to locate the cause. @chancharles92 you are probably more familiar with this gadget, do you have any clue where did i forget to update? update: fixed in 44b7c42 ✅ |
reminder for myself after I address comments for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
I agree with the removal of state field inside SolidityTranscript struct, because anyway it's not used to construct the hasher. Same field also exists in the RescueTranscript, we should consider removing that as well.
Should not we add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor comment. LGTM.
yes, but previously, we were using it. in this PR, we removed it.
that would require refactoring of the recursion circuit, since we are not using it atm, maybe we leave it as it is for now. cc @mrain |
we have already does the protection from the caller side: in let plookup_evals = if circuits[i].support_lookup() {
let evals = prover.compute_plookup_evaluations(
prove_keys[i],
&challenges,
&online_oracles[i],
)?;
transcript.append_plookup_evaluations::<E>(&evals)?;
Some(evals)
} else {
None
}; we only invoke it if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #618
This PR:
Changes behavior of
SolidityTranscript
, see the linked issue for descriptionThis PR does not:
Question: should we also optionally append
tau
for circuits that does support lookup? currently in contract, we have to do a uselessget_and_append_challenge
call for this unused challenge.@chancharles92 @philippecamacho
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
CHANGELOG.md
of touched crates.Files changed
in the GitHub PR explorer