Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scripts maintenance #620

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: scripts maintenance #620

merged 2 commits into from
Jun 26, 2024

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Jun 25, 2024

closes: #614

This PR:

  • Fix the test code coverage script.
  • Add the unstable option back for run_test.sh . Now it also report the test running time.

This PR does not:

Key places to review:

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain requested a review from philippecamacho June 25, 2024 15:23
@mrain mrain requested a review from alxiong as a code owner June 25, 2024 15:23
alxiong
alxiong approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's great that cargo +nightly works under nix now. previously I remember that even if we have the nightly toolchain (for fmt at least), this command won't work.

but i just tested now, it works.

@mrain
Copy link
Contributor Author

mrain commented Jun 25, 2024 •
edited
Loading

it's great that cargo +nightly works under nix now. previously I remember that even if we have the nightly toolchain (for fmt at least), this command won't work.

but i just tested now, it works.

I remember that it was the problem with displaydoc. Rust was tuning some feature that will cause compilation error. Now there're only warnings not errors.

@mrain mrain merged commit c73ad68 into main Jun 26, 2024
5 checks passed
@mrain mrain deleted the cl/fix-scripts branch June 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxiong alxiong alxiong approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage script does not work
2 participants
@mrain @alxiong