Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow to specify format (i.e. include appname in notification) #338

Closed
leon-erd opened this issue Nov 23, 2023 · 9 comments · Fixed by #354
Closed

[Feature] Allow to specify format (i.e. include appname in notification) #338

leon-erd opened this issue Nov 23, 2023 · 9 comments · Fixed by #354
Labels
enhancement New feature or request
Milestone

Comments

@leon-erd
Copy link

leon-erd commented Nov 23, 2023

Please read through the README and the Man pages before submitting
Please also make sure that there isn't any prior issue describing this feature

Is your feature request related to a problem? Please describe.
It would be nice for me to know which app is sending the notification.
A notification could be coming through my phone (via KDE Connect for example) or from my computer. They could have the exact same summary and body but would have different appnames.

Describe the solution you'd like
I would like the option to define in my config if the appname should be shown in the notifications or not.
Or to set a markup format similar to dunst. The following is copied from the dunstrc:
# The format of the message. Possible variables are:
# %a appname
# %s summary
# %b body
# %i iconname (including its path)
# %I iconname (without its path)
# %p progress value if set ([ 0%] to [100%]) or nothing
# %n progress value if set without any extra characters
# %% Literal %
# Markup is allowed
format = "%s\n%b\n%a"

The appname could also be used to infer an app icon like it is done in linux_notification_center which looks really nice:

20231123_16h45m45s_grim
Screenshotted from the linux_notification_center README

Additional context
Thanks for the overall really nice program!

@ErikReider ErikReider added the enhancement New feature or request label Nov 28, 2023
@ErikReider
Copy link
Owner

#61 would make it easier to identify which notifications are sent by which application

@leon-erd
Copy link
Author

If it would look like the screenshots from cosmic (with the icon and the app name for each notification / group) that would be perfect! Really looking forward seeing this!

@ErikReider
Copy link
Owner

If it would look like the screenshots from cosmic (with the icon and the app name for each notification / group) that would be perfect! Really looking forward seeing this!

#345 check this PR out :)

@leon-erd
Copy link
Author

I have already seen the PR :) However, in the video, there are no icons/app names for single notifications yet. I'm excited to test and see the changes once the PR is ready to use.

@ErikReider
Copy link
Owner

I have already seen the PR :) However, in the video, there are no icons/app names for single notifications yet. I'm excited to test and see the changes once the PR is ready to use.

image
This should solve your issue :)

@leon-erd
Copy link
Author

leon-erd commented Dec 5, 2023

That looks good! But will this also be available for single notifications that are not part of a group?

@ErikReider
Copy link
Owner

That looks good! But will this also be available for single notifications that are not part of a group?

Nope, couldn't find a way to make it look good. If you can find a nice design, I'll consider it :)

@leon-erd
Copy link
Author

leon-erd commented Dec 6, 2023

I think the Cosmic design actually looks really good and is pretty much what I am looking for.

150807140-cf407ab8-c311-46c9-bc34-46bac0e49708

I like it with the app name in a smaller font size above the bold summary. I think an option in the config to enable/disable the icon and app name would be perfect.
I also like the design of the linux_notification_center with the icon and app name in the bottom right as attached above.

@ErikReider
Copy link
Owner

image

This is a work in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants