WIP: v0.13.0 #2
Draft
WIP: v0.13.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They'll be rewritten later, this just makes future debugging easier.
The current Endorphin can not be build with WebKit/WebEngien trunk, so the WebKit/Engine version is always the one that is included in te used QT version by default.
Many features are still missing, and the Tests haven't been ported yet.
The first feature that is exclusive to WebEngine. WebEngine does not only remove features, but also makes new features possible.
Formatting using astyle Update nullptr usage using clang-tidy
This breaks the qmake system, but it will be removed soon, so fixing it isn't really needed
DownloadManager is currently broken, but I'll fix that.
Some tests did already support cmake, this adds the ones that were missing. Not all tests pass, but they now compile.
I don't see any benefit in using them, everything that autotests don't cover can be directly tested inside the browser.
AaronDewes
force-pushed
the
webengine
branch
from
1ed13aa
to
cc578ca
Compare
This will soon also suggest searching an input if it isn't a valid URL. History is currently not working.
This reverts commit f6f1505. This behavior should only be used on KDE right now, which has a seperate branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebEngine Port
This is the WebEngine version. A lot of things still need to be done, and I'm working on that. This is not finished yet, many features are still unavailable or not working properly.