Remove serde_json arbitrary precision feature

[trevor-crypto]

Is it possible to revert or modify the changes in this commit so that the serde_json arbitrary_precision feature is not enabled?

This can cause problems when using cardano-serialization-lib alongside other crates that also depend on serde_json but do not need the arbitrary_precision. The Rust feature resolver cannot compile two separate versions of serde_json, one with the feature and one without.

[lisicky]

Hi @trevor-crypto ! Unfortunately a plutus data integer size can be up to 64 bytes (not bits) and serde can't serialize values bigger than u64(8 bytes) without this feature. If you just have serde_json versions conflict you can override serde version for specific package in .toml file of your project.
If you provide more details we might help you to find solution for your issue.

[trevor-crypto]

If you just have serde_json versions conflict you can override serde version for specific package in .toml file of your project.

There's no way to do this because when you're using a workspace, the feature is enabled across the whole workspace, so every dependency and their dependencies get a compiled serde_json with arbitrary_precision enabled. The compiler doesn't compile two separate versions of serde_json, one with and one without arbitrary_precision.

Since serde_json is a common dependency of a lot of crates, this causes "feature leak" across the whole project.

Ex.

my_crate
|
- cardano-serialization-lib
  |
   - serde_json (with `arbitrary_precision`)
- other-blockchain-lib
  | 
   - serde_json (without `arbitrary_precision` but gets it anyway!)

[trevor-crypto]

@lisicky Can you explain this more or show me a test that checks this? It should be possible with your own deserializer/serializer that can handle a string <-> BitInt.

Unfortunately a plutus data integer size can be up to 64 bytes (not bits) and serde can't serialize values bigger than u64(8 bytes) without this feature.

[lisicky]

@trevor-crypto I have pushed a test 85398ed

It should be possible with your own deserializer/serializer that can handle a string <-> BitInt.

What do you mean ? We do not implement a serializer to a rust structure<->json serialization, we use serde for it

[lisicky]

We will add "arbitrary-precision-json" ( you can see it in the test ) feature into our crate, it enables "arbitrary_precision" for serde_json and it's default feature but you can just disable it in your project

[trevor-crypto]

@lisicky I understand now. So the BigInt cannot be a String and must be a Number in JSON format.

That fix works for me. Thanks!