Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for incoming ggplot2 version #145

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Update tests for incoming ggplot2 version #145

merged 2 commits into from
Jan 18, 2024

Conversation

teunbrand
Copy link
Contributor

Hi Emil,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break paletteer.

This PR updates tests to be compatible with both the old and new version of ggplot2.
Due to changes to the binned scale break calculation, the expected colours have changed slightly between versions of ggplot2.
Also we've changed the call field of scales to give more informative error messages about scales. However, this means that testing that scales are effectively equal needs a tweak to ignore the call field.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help paletteer get out a fix if necessary.

@EmilHvitfeldt
Copy link
Owner

Thank you @teunbrand !!

I'll make sure to get a release out beforehand

@EmilHvitfeldt EmilHvitfeldt merged commit 32af13b into EmilHvitfeldt:main Jan 18, 2024
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants