Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vangogh #133

Closed
cgoo4 opened this issue Oct 21, 2022 · 2 comments
Closed

Add vangogh #133

cgoo4 opened this issue Oct 21, 2022 · 2 comments
Labels
new palettes New palettes to be included

Comments

@cgoo4
Copy link

cgoo4 commented Oct 21, 2022

Hi Emil - please could you add van gogh ?

@EmilHvitfeldt EmilHvitfeldt added the new palettes New palettes to be included label Oct 21, 2022
@EmilHvitfeldt
Copy link
Owner

Hello @cgoo4 👋 I've marked it for next release

@EmilHvitfeldt
Copy link
Owner

EmilHvitfeldt commented Jan 20, 2024

https://github.com/cherylisabella/vangogh

  • Modify data-raw/palettes_d.R
  • Modify and Run data-raw/palettes_d_names.R script
  • run devtools::document()
  • Include license reference in LICENSE file.
  • Include package information in data-raw/packages and run.
  • reknit readme.
  • Include bullet in NEWS.md file.
  • run data-raw/palette_names.R
  • run testthat::snapshot_review('vdiffr_palette_check')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new palettes New palettes to be included
Projects
None yet
Development

No branches or pull requests

2 participants