Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] nn.seqBRNN ability to stack and maskZero() #421

Open
jpilaul opened this issue Aug 24, 2017 · 0 comments
Open

[Feature request] nn.seqBRNN ability to stack and maskZero() #421

jpilaul opened this issue Aug 24, 2017 · 0 comments

Comments

@jpilaul
Copy link

jpilaul commented Aug 24, 2017

I am currently doing something like this:
brnn = nn.seqBRNN(vec_size,rnn_size)
brnn.forwardModule:maskZero()
brnn.backwardModule:maskZero()
I have extended seqBRNN to add the ability stack seqBRNN with a stack_size argument that adds modules in a loop. I also added a seqBRNN:maskZero() method on my local repo.

If this is something that you might want, should I send a merge request?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant