From 19da7f47b158b0d851fbd44e89ed41e3c4cc1a23 Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Wed, 24 Apr 2024 23:44:10 +0900 Subject: [PATCH 1/7] change: target dotnet version --- nuke/_build.csproj | 2 +- src/ElectronNET.API/ElectronNET.API.csproj | 2 +- src/ElectronNET.CLI/ElectronNET.CLI.csproj | 2 +- src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/nuke/_build.csproj b/nuke/_build.csproj index 7521e1ba..4868d0d7 100644 --- a/nuke/_build.csproj +++ b/nuke/_build.csproj @@ -2,7 +2,7 @@ Exe - net6.0 + net8.0 CS0649;CS0169 .. diff --git a/src/ElectronNET.API/ElectronNET.API.csproj b/src/ElectronNET.API/ElectronNET.API.csproj index e4d22216..1f44ff76 100644 --- a/src/ElectronNET.API/ElectronNET.API.csproj +++ b/src/ElectronNET.API/ElectronNET.API.csproj @@ -1,6 +1,6 @@  - net6.0 + net8.0 ..\..\artifacts ElectronNET.API Gregor Biswanger, Florian Rappl diff --git a/src/ElectronNET.CLI/ElectronNET.CLI.csproj b/src/ElectronNET.CLI/ElectronNET.CLI.csproj index 2023d894..fb335885 100644 --- a/src/ElectronNET.CLI/ElectronNET.CLI.csproj +++ b/src/ElectronNET.CLI/ElectronNET.CLI.csproj @@ -1,7 +1,7 @@  Exe - net6.0 + net8.0 dotnet-electronize electronize DotnetCliTool diff --git a/src/ElectronNET.WebApp/ElectronNET.WebApp.csproj b/src/ElectronNET.WebApp/ElectronNET.WebApp.csproj index e2691a1d..41ea283f 100644 --- a/src/ElectronNET.WebApp/ElectronNET.WebApp.csproj +++ b/src/ElectronNET.WebApp/ElectronNET.WebApp.csproj @@ -1,6 +1,6 @@  - net6.0 + net8.0 OutOfProcess AspNetCoreModule win-x64 From 7be796f77bd86750c30795c102aa45787461b48c Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Thu, 25 Apr 2024 00:34:38 +0900 Subject: [PATCH 2/7] upgrade: dependency * nuke 6.2.1 -> 8.0.0 --- nuke/Build.cs | 4 ++-- nuke/_build.csproj | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nuke/Build.cs b/nuke/Build.cs index 87b753d0..0b390254 100644 --- a/nuke/Build.cs +++ b/nuke/Build.cs @@ -109,7 +109,7 @@ protected override void OnBuildInitialized() .Before(Restore) .Executes(() => { - SourceDirectory.GlobDirectories("**/bin", "**/obj").ForEach(DeleteDirectory); + SourceDirectory.GlobDirectories("**/bin", "**/obj").ForEach(dir => dir.DeleteDirectory()); }); Target Restore => _ => _ @@ -244,7 +244,7 @@ protected override void OnBuildInitialized() throw new BuildAbortedException("Could not resolve the NuGet API key."); } - foreach (var nupkg in GlobFiles(ResultDirectory, "*.nupkg")) + foreach (var nupkg in ResultDirectory.GlobFiles("*.nupkg")) { DotNetNuGetPush(s => s .SetTargetPath(nupkg) diff --git a/nuke/_build.csproj b/nuke/_build.csproj index 4868d0d7..a71fa1bd 100644 --- a/nuke/_build.csproj +++ b/nuke/_build.csproj @@ -11,7 +11,7 @@ - + From 2edad2d32923a9ffc2cf065e3e2ee0ec90d3d8ad Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Thu, 25 Apr 2024 00:58:27 +0900 Subject: [PATCH 3/7] upgrade: dependencies version --- src/ElectronNET.CLI/ElectronNET.CLI.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ElectronNET.CLI/ElectronNET.CLI.csproj b/src/ElectronNET.CLI/ElectronNET.CLI.csproj index fb335885..5123f836 100644 --- a/src/ElectronNET.CLI/ElectronNET.CLI.csproj +++ b/src/ElectronNET.CLI/ElectronNET.CLI.csproj @@ -71,11 +71,11 @@ - + all runtime; build; native; contentfiles; analyzers - + all From a893ccd646123e0019381a186ea50977600011fa Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Thu, 25 Apr 2024 00:58:50 +0900 Subject: [PATCH 4/7] fix: debug workflows --- .vscode/launch.json | 4 ++-- .vscode/tasks.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index ff9df192..cec34592 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -10,9 +10,9 @@ "request": "launch", "preLaunchTask": "build", // If you have changed target frameworks, make sure to update the program path. - "program": "${workspaceRoot}/ElectronNET.CLI/bin/Debug/netcoreapp2.0/dotnet-electronize.dll", + "program": "${workspaceRoot}/src/ElectronNET.CLI/bin/Debug/net8.0/dotnet-electronize.dll", "args": [], - "cwd": "${workspaceRoot}/ElectronNET.CLI", + "cwd": "${workspaceRoot}/src/ElectronNET.CLI", // For more information about the 'console' field, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#console-terminal-window "console": "internalConsole", "stopAtEntry": false, diff --git a/.vscode/tasks.json b/.vscode/tasks.json index fb72f4ef..03554c8e 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -7,7 +7,7 @@ "label": "build", "type": "shell", "command": "dotnet", - "args": ["build", "${workspaceRoot}/ElectronNET.CLI/ElectronNET.CLI.csproj"], + "args": ["build", "${workspaceRoot}/src/ElectronNET.CLI/ElectronNET.CLI.csproj"], "problemMatcher": "$msCompile", "group": { "_id": "build", From 96ae77ceb42be81e9fffb94a27282058159ae423 Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Thu, 25 Apr 2024 01:01:22 +0900 Subject: [PATCH 5/7] update: workflow --- .github/workflows/ci.yml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 81c61026..0901bd2c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,14 +11,13 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup dotnet - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: | - 6.0.x - 7.0.x + 8.0.x - name: Build run: ./build.sh @@ -27,14 +26,13 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup dotnet - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: | - 6.0.x - 7.0.x + 8.0.x - name: Build run: | From 286978c5230d52d16ec6ffbea2ae0be7bcb03018 Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Thu, 25 Apr 2024 17:27:45 +0900 Subject: [PATCH 6/7] update: readme.md .net 6 -> .net 8 --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 32b7634f..c145a0d4 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ [![donate](https://img.shields.io/badge/Donate-Donorbox-green.svg)](https://donorbox.org/electron-net) [![Gitter](https://badges.gitter.im/ElectronNET/community.svg)](https://gitter.im/ElectronNET/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge) [![Build status](https://github.com/ElectronNET/Electron.NET/actions/workflows/ci.yml/badge.svg)](https://github.com/ElectronNET/Electron.NET/actions/workflows/ci.yml) -Build cross platform desktop apps with .NET 6 and Blazor, ASP.NET Core (Razor Pages, MVC). +Build cross platform desktop apps with .NET 8 and Blazor, ASP.NET Core (Razor Pages, MVC). Electron.NET is a __wrapper__ around a native Electron application with an embedded ASP.NET Core application. Via our Electron.NET IPC bridge we can invoke Electron APIs from .NET. @@ -18,7 +18,7 @@ Well... there are lots of different approaches how to get a X-plat desktop app r ## 🛠 Requirements to Run -The current Electron.NET CLI builds Windows/macOS/Linux binaries. Our API uses .NET 6, so our minimum base OS is the same as [.NET 6](https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.md). +The current Electron.NET CLI builds Windows/macOS/Linux binaries. Our API uses .NET 8, so our minimum base OS is the same as [.NET 8](https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md). Also you should have installed: From dbcd4ac940f1591a98dc272779d76da78bd93482 Mon Sep 17 00:00:00 2001 From: Lemon73-Computing Date: Fri, 26 Apr 2024 19:42:32 +0900 Subject: [PATCH 7/7] add: setting self-contained --- src/ElectronNET.CLI/ElectronNET.CLI.csproj | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ElectronNET.CLI/ElectronNET.CLI.csproj b/src/ElectronNET.CLI/ElectronNET.CLI.csproj index 5123f836..fd30a574 100644 --- a/src/ElectronNET.CLI/ElectronNET.CLI.csproj +++ b/src/ElectronNET.CLI/ElectronNET.CLI.csproj @@ -25,6 +25,7 @@ Changelog: https://github.com/ElectronNET/Electron.NET/blob/main/Changelog.md PackageIcon.png true + true