Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 Maintainability issues in main\downloadManager.js #14

Open
2 tasks
rustdevbtw opened this issue Dec 22, 2021 · 2 comments
Open
2 tasks

Fix 2 Maintainability issues in main\downloadManager.js #14

rustdevbtw opened this issue Dec 22, 2021 · 2 comments
Assignees
@Patrick-web
Labels
question Further information is requested

Comments

@rustdevbtw
Copy link
Member

CodeFactor found multiple issues:

'fileURL' is defined but never used.

'downloadFile' is defined but never used.

And why https://ovh.net/files/1Gio.dat (1GB in size) is downloaded?

@Patrick-web
@rustdevbtw rustdevbtw added the question Further information is requested label Dec 22, 2021
@jdev082
Copy link

jdev082 commented May 31, 2022

'defined but never used', that means they can just be deleted right?

@rustdevbtw
Copy link
Member Author

@JaydenDev It's weird but true. Actually, the codebase is messy and needs a cleanup. Additionally, the new re-written version of Electron App Store would take some time to complete (as I'm working on it alone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patrick-web Patrick-web

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Patrick-web @rustdevbtw @jdev082