-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make xcframework
done manually by PR authors is error-prone and a potential security hazard
#99
Comments
@nuttycom wrote:
|
Related to the comment of mine that @daira mentioned, this repository should no longer be maintained under
|
- builds the existing rust code - packages into Xcframework - updates the Swift package directory - zips and calculates SHA-256 of xcframework - updates the Package.swift with the artifact url and checksum - commits the changes, pushes them and tags the repo - creates a Github Release with notes that have the Diff and checksum closes #2 closes Electric-Coin-Company#99
- builds the existing rust code - packages into Xcframework - updates the Swift package directory - zips and calculates SHA-256 of xcframework - updates the Package.swift with the artifact url and checksum - commits the changes, pushes them and tags the repo - creates a Github Release with notes that have the Diff and checksum closes #2 closes Electric-Coin-Company#99
- builds the existing rust code - packages into Xcframework - updates the Swift package directory - zips and calculates SHA-256 of xcframework - updates the Package.swift with the artifact url and checksum - commits the changes, pushes them and tags the repo - creates a Github Release with notes that have the Diff and checksum closes #2 closes Electric-Coin-Company#99
Ideally
make xcframework
would be automatic. Having it be done manually by the committer is error-prone and results in PRs that can't be fully reviewed, which is a security hazard (for example if the committer's machine / build environment is compromised).If
make xcframework
is deterministic (I don't know whether it is or could be made so), then perhaps a CI step could domake clean xcframework
and then check that the resulting tree is clean.Originally posted by @daira in #98 (comment)
The text was updated successfully, but these errors were encountered: