Migrating from AMS

[dgmora]

Hi, I've seen the guide and I'm trying to follow it but there are some points that I didn't find.

The are some things that I'm not sure how to change that are blocking me at the moment. One is that I thought that I could keep associations using AMS, but it seems that doesn't work:

class MySerializer < Oj::Serializer
  belongs_to :user, serializer: MyAMSUserSerializer
end

This throws:

      NoMethodError:
        undefined method `one_as_hash' for MyAMSUserSerializer:Class
      # (eval):7:in `render_as_hash'
      # /Users/david/.local/share/rtx/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/oj_serializers-2.0.2/lib/oj_serializers/serializer.rb:209:in `one_as_hash'
      # /Users/david/.local/share/rtx/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/oj_serializers-2.0.2/lib/oj_serializers/serializer.rb:164:in `render'

I have compat required.

The other is that scope isn't part of the DSL.

Some other points that I noticed that I had to change, that I think at some point I can manage to fix:

• type doesn't exist as part of the DSL
• • Haven't checked yet how to replace it yet, but link also isn't part of the DSL
• unless doesn't exist as opposite as if
• Had to replace key: with as:

Don't take me wrong, the library looks pretty promising and I understand replicating the whole AMS API isn't the goal, but I'm trying to figure out how to make the change!

[ElMassimo]

Hi David!

undefined method `one_as_hash'

Thanks for reporting, this is a bug in the latest versions, have a fix here:

• fix: allow using active_model_serializers in associations (compat) #12

unless doesn't exist as opposite as if
Had to replace key: with as:

These were low-hanging fruit, implemented in:

• feat: add support for key and unless in ams compat mode

---

scope is not implemented in compat-mode because it makes serializers context-dependent, and is too implicit, making it more difficult to understand and unit test them.

Usually, the best approach is to pass any additional information the serializer needs as options. As a temporary measure during migration, you could also use something like RequestLocals to share the current controller (or current user) and define helper methods in your base serializer.

---

type and link don't exist as part of the DSL

This library targets active_model_serializers 0.8-ish, not 0.10.

[dgmora]

That was quick! I'll give it a try with these changes