Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicates from export formats #67

Open
peterstadler opened this issue Sep 29, 2024 · 3 comments
Open

remove duplicates from export formats #67

peterstadler opened this issue Sep 29, 2024 · 3 comments
Assignees
@peterstadler @riedde

Comments

@peterstadler
Copy link
Member

duplicates are propagated to the export formats (thus being published to Zenodo) without proper ID at the root element. Either this should be fixed or even better those duplicates should be removed from the export completely.
@peterstadler peterstadler self-assigned this Sep 29, 2024
@riedde riedde self-assigned this Sep 29, 2024
@riedde
Copy link
Contributor

riedde commented Sep 29, 2024

Could you give a more concrete hint or example?

@peterstadler
Copy link
Member Author

Sure, here is an example:
The letter A040001 is a duplicate, i.e. this "letter" got moved to the documents section with the ID A100245 at some time.
The file with the old ID is still kept in our subversion but it redirects to the new location via <ref type="duplicate" target="A100245"/>.

The transformation to tei_all (and all other export formats based on this) are now converting the duplicates to "proper" TEI files, yet without any @xml:id on the <TEI> element, see

WeGA-ODD/xsl/to-tei_all.xsl

Lines 240 to 277 in 51a662c

<xsl:variable name="duplicatesWrapper" as="element()">
<TEI xmlns="http://www.tei-c.org/ns/1.0">
<teiHeader>
<fileDesc>
<titleStmt>
<title level="s">WeGA, Digitale Edition</title>
<title level='a'>Duplikat</title>
<editor>Veit, Joachim</editor>
<editor>Stadler, Peter</editor>
</titleStmt>
<publicationStmt>
<publisher>
<name>Carl-Maria-von-Weber-Gesamtausgabe</name>
<address>
<street>Hornsche Str. 39</street>
<postCode>32756</postCode>
<placeName>
<country>D</country>
<settlement>Detmold</settlement>
</placeName>
</address>
</publisher>
<availability>
<licence target="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International (CC BY 4.0)</licence>
</availability>
</publicationStmt>
<sourceDesc>
<p>born digital</p>
</sourceDesc>
</fileDesc>
</teiHeader>
<text>
<body>
<p>Dies ist ein Duplikat!</p>
</body>
</text>
</TEI>
</xsl:variable>

This struck me during the eXist workshop at the Edirom Summer School I was giving with @martinascholger where we were using the WeGA-data package from Zenodo.

Right now I'm thinking of removing those duplicates from the export – or can you think of any benefit of keeping them?

@riedde
Copy link
Contributor

riedde commented Oct 4, 2024

No, I also think that this is a way to resove that issue. The duplicates are neccessary for internal reasons (forwarding). Or might this also be important for the export? Should we keep this information, e.g., by adding the "old" fileID to the header? Something like an "alternative (former) identifier".
But independent from that, removing those "pointer-files" from the export is maybe less invasive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterstadler peterstadler

@riedde riedde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterstadler @riedde