Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling issue of the footer on forms/details-source.xml #182

Closed
peterstadler opened this issue Nov 16, 2023 · 2 comments · Fixed by #183
Closed

styling issue of the footer on forms/details-source.xml #182

peterstadler opened this issue Nov 16, 2023 · 2 comments · Fixed by #183
Assignees
Labels
layout Frontend issues, most probably CSS-related
Milestone

Comments

@peterstadler
Copy link
Member

the footer of forms/details-source.xml apparently misses some CSS, see Screenshot and compare with the landing page at index.html:
Bildschirmfoto 2023-11-16 um 14 38 51

@peterstadler peterstadler added this to the Release 2.0 milestone Nov 16, 2023
@peterstadler
Copy link
Member Author

The issue also appears on forms/details-expression.xml and forms/details-reference.xml, and probably other details-* pages?

@daniel-jettka daniel-jettka self-assigned this Nov 16, 2023
@daniel-jettka
Copy link

daniel-jettka commented Nov 16, 2023

due to an issue with the contrast on the details pages with a very light colored background I would propose...

  • option (a) to make the font color in the footer lighter. An alternative would be...
  • option (b) to have different CSS directives for different background colors.

This is what it looks like with a lighter font color:

image

image

For the history details page it's still not very nice, but maybe still better than having multiple font color definitions...

image

@peterstadler peterstadler added the layout Frontend issues, most probably CSS-related label Nov 16, 2023
@peterstadler peterstadler linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layout Frontend issues, most probably CSS-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants