Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match rules in webextension limited to only few URI schemes #3

Open
Ede123 opened this issue Apr 23, 2017 · 4 comments
Open

Match rules in webextension limited to only few URI schemes #3

Ede123 opened this issue Apr 23, 2017 · 4 comments

Comments

@Ede123
Copy link
Owner

Ede123 commented Apr 23, 2017

@ExE-Boss OK, I'm afraid I found an issue with the webextension:
The "matches": ["<all_urls>"] in manifest.json only works for the URI schemes "http", "https", "file", "ftp" and "app".

This fails for example when looking at data URIs.

It's only a minor issue, but as I don't see any real advantage of having a webextension I obviously don't want to sacrifice functionality for it.

@Ede123
Copy link
Owner Author

Ede123 commented Apr 23, 2017

Other obvious example that does not match: about:logo

Not working either: All chrome:// links.

@Ede123 Ede123 changed the title Match rules in webextension Match rules in webextension limited to only few URI schemes Apr 23, 2017
@ExE-Boss
Copy link
Collaborator

ExE-Boss commented Apr 23, 2017

Sadly, content scripts can't work with about:* or chrome:// links, as those are privileged Firefox pages.
The advantage of having a WebExtension is that it will work in Firefox 57+.
Data URIs don't work because Firefox doesn't inject scripts into those, but support for those might be added if we file a bug at https://bugzilla.mozilla.org.

@Ede123
Copy link
Owner Author

Ede123 commented Apr 23, 2017

Oh come on... Who signed off on all this crap? Why should I want to work with a "secure" browser if it means the browser is unwilling to work with me?

Thanks for clarification, but as it stands that means I'll hold of on any update until there's no way around webextensions anymore.
If they already fail to meet the requirements for an extremely simple add-on like Nicer Media Pages, how should they ever allow anything really useful to be made?

@ExE-Boss
Copy link
Collaborator

ExE-Boss commented Nov 8, 2017

Update: Firefox Quantum (57) is coming within a week, so it might be a good idea to have the new version submitted to AMO already, so that it can be reviewed and approved in time.

Ede123 added a commit that referenced this issue Nov 15, 2017
This is because of limitations in the webextension version, see #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants